Guy Carmeli
61a9abeaf1
Fix infinite loop while trying to remove react buttons
5 년 전
Yogev Ben David
a8175ef272
Fix button with react component doesn't get unmounted (#5457 )
* Fix button with react component doesn't get unmounted
* Test e2e only on iOS
5 년 전
Guy Carmeli
8f2463e0da
Rename all the things (#5455 )
Break all the PRs :(
iOS and Android code base used different naming conventions - this commit aims to unify naming conventions. I probably missed a few properties here and there so this will be an ongoing effort.
5 년 전
Yogev Ben David
ac60d2fe6a
Handle adding and removing components from registry manually by presenters (#4942 )
5 년 전
Yogev Ben David
0186b1ac36
Prevent retaining button component in componentRegistry (#4888 )
5 년 전
Yogev Ben David
7e15d59bbc
Remove get current leaf, better options resolving (#4700 )
* Remove currentLeaf
* Fix resolve options
* Remove irrelevant test
* Remove RNNRootViewController clear background color
* Fix title with subtitle options
5 년 전
Yogev Ben David
5abea28c53
SetRoot wait for render (#4688 )
* Layout changes
* WIP
* Revert "Layout changes"
This reverts commit 4da8cfbd12 .
* Clean topBar.component and topBar.background.component when not needed
* Move custom components login from viewController to presenters
* Change waitForRender and enabled property from primitive bool to Bool object
* Fix ios unit tests
* Add unit tests
* Remove RNNReactView observer when view ready
* Load react components from component manager
* Remove createCustomReactView duplication
* Handle render children in each Layout
* Wait for navigation presenter components render, refactor RNNTitleViewHelper
* Fix unit tests
* Add waitForRender for custom react components
* Fixes e2e
5 년 전