Error in AppDelegate.m since there was no return statement. (#1945)
Since the docs suggested we remove everything inside the `didFinishLaunchingWithOptions`, without the return statement there was an `Control reaches end of non-void function` error since the function expects a boolean return. After adding this, the error goes away.
Backwards compatibility for clearHostOnActivityDestroy (#1944)
This commit fixes two issues found in #1838. Fixes #1924
1. Keeps calling the deprecated reactInstanceManager methods when host is cleared
to not introduce undesired behavior when clearHostOnActivityDestroy return true.
2. call onHostDestroy and onHostPause only if react context exists or is being created.
* remove unused code from tabStyle
* improve dummy screen ui
* set list screen translucent navigation bar
* make RCCToolBarView to composite the UIRootView inside
* add list screen for debug behaviours
* add dummy screen
* ui changes in ListScreen
* add push list screen function without add it to the button to the screen
* add and comment push list screen row
This commit adds support for fade and slide-horizontal animations for modals and a few other animation related changes:
* Support defining animationType when calling dismissModal
* Support fade and slide horizontal animations for modals
* Slightly reworked current screen animations timings
* Fixed slide-horizontal x offset and removed alpha
* android oreo overdraw fix
* apply top bar title color
* update readme
* update formatting
* merge v2
* navigation oprtions formatting
* font size props
* update test
* ci fix
* rm global variable
* font size
* update readme
* playground
* after merge fix
Stop calling host.clear() when activity is destroyed (#1838)
This is a breaking change and has to be opt-in. To prevent host.clear from being called,
Override `clearHostOnActivityDestroy` in MainApplication and return false:
```java
@Override
public boolean clearHostOnActivityDestroy() {
return false;
}
```
If host isn't cleared, the next time the app is opened react context might still be initialized.
In this case we emit appLaunched event which has to be handled in Js:
```js
Promise.resolve(Navigation.isAppLaunched())
.then((appLaunched) => {
if (appLaunched) {
startApp();
}
new NativeEventsReceiver().appLaunched(() => {
startApp();
});
})
```