Guy Carmeli
aa8135dcbf
Don't crash if Modal related commands are called before root is set
We should also support showingModals on Android regardless of root
il y a 6 ans
Yogev Ben David
feab91de5c
Closes #3545 (#3874 )
il y a 6 ans
Spencer Kingman
5cecd814f6
Update Installing.md (#3870 )
Some extra help concerning a common issue that occurs with fresh install of Xcode + react native 0.56. https://github.com/react-community/create-react-native-app/issues/316#issuecomment -351371080
il y a 6 ans
Guy Carmeli
98053e60ec
Update docs
il y a 6 ans
Guy Carmeli
3074407577
Delegate onNewIntent to reactInstanceManager
il y a 6 ans
Sergey Ilyevsky
ed657c99a1
Removed the headers form copy build phase - they are copied as headers. This was causing build error on Xcode 10 (#3774 )
il y a 6 ans
Rizwan Mohamed Ibrahim
6e8495015b
Add addtional common problem for cache reset (#3809 )
When fresh installing `v2` branch some time getting issues with bundling. Due to `rn-packager` cache. Normal `npm start -- --reset-cache` was not working properly. So had to reset the cache manually. Maybe its because of the start script is different from regular react native app setup
il y a 6 ans
Spencer Kingman
59cfb6a50d
Update Installing.md (#3847 )
Fix an imprecise path name, and fix a meaningful typo `No Run --> Now run`.
il y a 6 ans
Spencer Kingman
af3de1558b
Update Installing.md (#3871 )
Change `index.ios` to `index` in `AppDelegate.m`.
il y a 6 ans
Birkir Rafn Guðjónsson
39c10bd934
URLs in docs are case sensitive (#3750 )
Fixing 404 not found
il y a 6 ans
Guy Carmeli
a1b91cd452
Don't parse back button is json is empty
il y a 6 ans
Guy Carmeli
b6520cd337
fix lint
il y a 6 ans
Guy Carmeli
97b83e8124
Add YellowBoxed back to ReactRootViews before unmount
Apparently, UiImplementation doesn't like it when views disappear from hierarchy unexpectedly.
As yellow boxes are added to all ReactRootViews, we remove them from TopBar components.
When these components got unmounted, UiImplementation tried to remove the yellow box and since it
couldn't find it - it crashed.
This commit simply adds the yellow box before views are unmounted.
il y a 6 ans
Raphael Hovsepyan
7ac78c2b3c
Fix setStackRoot animation documentation (#3849 )
il y a 6 ans
Vahid Boreiri
6c3fb8d3e9
Fix some typo issues. (#3852 )
il y a 6 ans
yogevbd
dfa6ba6c4d
Closes #3861
il y a 6 ans
Guy Carmeli
fd483a00ea
Emit ModalDismissed event before resolving dismissModal promise
il y a 6 ans
Guy Carmeli
5d54ed5bf9
Fix unit tests Android
Stack related options are applied only if the view is visible, for now this is a reasonable fix.
il y a 6 ans
Guy Carmeli
2fb2885608
Merge child options in stack controller only if child is visible
This needs to be addressed for other ParentControllers as well
il y a 6 ans
Guy Carmeli
8948b6af0c
Restore detox timeout value
il y a 6 ans
Guy Carmeli
68373759c0
Button unmount (#3856 )
Unmount buttons when corresponding screen is unmounted
Currently buttons were unmounted each time a screen was pushed to the stack.
As we're clearing props when screens are unmounted from the prop store - when a screen
was popped to - its buttons's props were undefined.
This commit changes things so that buttons are unmounted when buttons are set
using mergeOptions and when the corresponding screen is unmounted.
il y a 6 ans
yogevbd
47abec7f10
Closes #3823
il y a 6 ans
yogevbd
26616fc4cc
handle buttonPressed event in rootViewController
il y a 6 ans
yogevbd
cc88900123
fixes crash on iOS
il y a 6 ans
Shalom Yerushalmy
f66556accf
Gradle version back to 3.0.1
il y a 6 ans
Shalom Yerushalmy
293d6bc195
Fix broken jenkins build status badge
il y a 6 ans
Shalom Yerushalmy
d0aa2e2c0b
Update build.gradle
il y a 6 ans
yogevbd
caff3b8801
Fixes button react component props
il y a 6 ans
Shalom Yerushalmy
f36f5dc0c3
Downgrade gradle version from 3.1.4 to 3.1.0
il y a 6 ans
Shalom Yerushalmy
ee34b86f26
Upgrade gradle from 3.0.1 to 3.1.4
il y a 6 ans
yogevbd
62125f9a8f
reset badge with an empty string
il y a 6 ans
Guy Carmeli
2002020aae
Emit modalDismissed event when dismissingAllModals as well
il y a 6 ans
yogevbd
d4879c8cd6
remove yellow boxes on iOS
il y a 6 ans
yogevbd
e50c62eb5b
Downgraded detox in order to fix e2e
il y a 6 ans
Guy Carmeli
81d491f285
Temporarily fix failing e2e test on iOS
il y a 6 ans
Guy Carmeli
3a327c62cb
Add ModalDismissed to supportedEvents on iOS
il y a 6 ans
yogevbd
b8945a26d5
fix header alignment
il y a 6 ans
Guy Carmeli
a322875c98
Rename Color to Colour
As RNN's Color is used frequently with Android's Color class, we had to use fully qualified names, the rename avoids this.
il y a 6 ans
Guy Carmeli
9543b539d5
Emit modalDismissed event when modals are dismissed on Android
il y a 6 ans
Guy Carmeli
5eee64a0ea
Hide YellowBox in TopBar components
il y a 6 ans
yogevbd
27a6bb653f
fix custom header component
il y a 6 ans
Guy Carmeli
7470f02045
Handle waitForRender when displaying Modals without animation
il y a 6 ans
yogevbd
28322c71ce
fixes react component as titleView
il y a 6 ans
Yogev Ben David
5162f17bef
fix custom header (#3798 )
* fix custom header
* fix e2e
il y a 6 ans
Yogev Ben David
069f1a7408
Upgrade to detox 8.x.x (#3811 )
il y a 6 ans
Yogev Ben David
ea00ae09e0
Detach button react view on reload (#3805 )
il y a 6 ans
Guy Carmeli
64ddd95e4e
Pass defaultOptions to Stack options presenter
il y a 6 ans
Guy Carmeli
93a448fe95
Apply topMargin only if defined
il y a 6 ans
Guy Carmeli
319d9c8662
Always apply topMargin
Check LayoutParams before applying, set 0 topMargin if margin is not provided to reset margin.
il y a 6 ans
Daniel Zlotin
c657ff9fd6
update docs
il y a 6 ans