Delete code related to old SideMenu implementation (#5254)
V1 had two SideMenu implementations. In v2 we've decided to stick with one and for some reason
code related to the unsupported implementation was left in the project.
This approach is still not ideal as it assumes there's a visible stack somewhere in the Hierarchy.
It's better than the current implementation so I'm pushing it and will reiterate in the future if needed.
This is an example of how to use React’s Context API and RNN. This solution isn’t ideal, hopefully someone
would be able to build upon this example and improve it.
Fix setStackRoot crash when called with the same id (#5154)
When a Stack’s root was set with an id of one of the Stack’s current children, there was a crash
since the wrong elements were removed from the stack.
This commit fixes this by creating a new stack when setStackRoot is called, and destroying all ViewControllers from the previous Stack.
Fixes #5117
Fix Topbar custom component flicker across screens #3864 (#5110)
When a topBar.backgroundComponent is defined, check if a corresponding ReactView has already been created with matching componentName and componentId. If such view is found, reuse it instead of creating another view.
This change will fix a flickering in the TopBar background component when a screen was pushed into a stack with a background component.
Explicitly clear bottom tabs options after mergeOptions (#5107)
When mergeOptions was called on a root view, it’s one time options weren’t cleared properly.
The entire one time options logic is terrible and has to be refactored out.
Fixes #5010