[V2][iOS] Added waitForRender support for setStackRoot (#5141)
* Properly check setStackRoot animation and waitForRender of each child
* Read waitForRender from the last child of the new stackRoot
* Fixed indentation
* Use setStackRoot.waitForRender instead of push.waitForRender
* Fixed merge issues caused by the text editor
* removed eof newline
* Added a missing semicolon
* Variable toVC renamed to newVC for consistency
* Fixed indentation problems
Fix rare race condition when applying bottomTabs.drawBehind (#5326)
When setting BottomTabs root, if one of the children was a stack with multiple children
and the top child in the stack had `drawBehind: true` while the bottom child had `drawBehind: false`,
sometimes the tabs' bottomMargin would be wrong since it was applied in onPreDraw.
Apply TopBar buttons only if they are different than current buttons (#5314)
Like all other options, buttons are applied when a screen becomes visible. This means that in a BottomTabs layout,
options are applied when a tab is selected. Since tab change happens involves only changing view visibility, and button creation take a bit long,
the buttons appear to flicker some times.
Ensure appLaunched event is emitted only when app is resumed
Under certain conditions, app launched event was emitted when the Android Activity isn't in resumed state. In this case, setting root isn't possible since ReactContext doesn't have an instance of the Activity (it can even be destroyed).
This PR ensures the event is emitted only when the Activity is resumed and root can be set.
New detox test command to run test cases when device is locked, one f… (#5159)
new detox test command to run test cases when device is locked, one failing test case for Android when app is running by tapping on a notification and device is locked and the app is not running in the background.
Allow setting UITabBarItem.title to default value (#5280)
The default value for `UITabBarItem.title` is `nil` as specified by the docs:
> You should set this property before adding the item to a bar. The default value is nil.
https://developer.apple.com/documentation/uikit/uibaritem/1616412-title
This changes allows for this to be `nil`.
Delete code related to old SideMenu implementation (#5254)
V1 had two SideMenu implementations. In v2 we've decided to stick with one and for some reason
code related to the unsupported implementation was left in the project.
This approach is still not ideal as it assumes there's a visible stack somewhere in the Hierarchy.
It's better than the current implementation so I'm pushing it and will reiterate in the future if needed.