yogevbd
7974b00307
fixes #3182
6 years ago
Guy Carmeli
86f7fc00fe
Add missing file
Options.java was missing from previous commit
6 years ago
Guy Carmeli
6a69287242
Removed NavigationOptionsListener
This commit removes NavigationOptionsListener as it was not needed anymore.
As a result, it uncovered a few issues which this commit also aims to fix.
* Set SideMenuController as parent of left, right and centre controllers
* Select tab by id with tabSelector interface
* mergeOptions now also applies options after merge - in ViewController base class
* Pull presentation logic from ComponentLayout to ComponentViewController
6 years ago
Guy Carmeli
c47a3771ea
empty commit
6 years ago
Guy Carmeli
813af3492d
empty commit
6 years ago
Jin Shin
af5538af19
Fixed wrong Android React Native path. (#3180 )
6 years ago
Guy Carmeli
fac293dbfc
point to index.js in build.gradle
6 years ago
Guy Carmeli
60fdb64a14
Point to index.js in xcode build scripts
6 years ago
Guy Carmeli
746f240ec5
Expose ReactNativeHost creation in NavigationApplication
This commit also consolidates index files in the playground app
6 years ago
Shalom Yerushalmy
6768876066
Fix lint
6 years ago
Guy Carmeli
ce806e3b1e
Destroy Overlay when it is dismissed
* Cover OverlayManager with unit tests
* Add e2e to test Overlay unmount
6 years ago
yogevbd
9391cd52fd
Custom titleView layout fix
6 years ago
yogevbd
61695e0e08
fixed apply options
6 years ago
Guy Carmeli
e006406ceb
Emit bottomTabSelected event
6 years ago
Guy Carmeli
07050db9f9
Command (#3175 )
* Assign commandId to async commands
* CommandListener refactor
Pull listener out of Navigator and implement NativeCommandListener for native commands
* Emit onNavigationEvent when commands complete
* Rename timestamp to completionTime
* Rename NavigationEvent to EventEmitter
* Rename sendOnNavigationButtonPressed to emitOnNavigationButtonPressed
* Emit navigationEvent on bottom tab select
* rebase fix
* Emit commandCompleted event instead of nativeEvent
* fix native ios commands
* wait show and dismiss Overlay
6 years ago
andresesfm
935557a2ef
Implemented test for public constructor (#3153 )
6 years ago
yogevbd
3761a976e0
reset buttons to avoid react component recreation
6 years ago
yogevbd
4387d4fd4b
merge options only when viewController is loaded and visible
6 years ago
yogevbd
3d22e69d6a
Fix appLaunched and button press events on iOS
6 years ago
Guy Carmeli
1d2680c5aa
Fix appLaunched and button press events on Android
Both events broke in 104e3f97
6 years ago
Daniel Zlotin
ab8ba4e659
update docs
6 years ago
Daniel Zlotin
104e3f97fd
BREAKING events api
6 years ago
Shalom Yerushalmy
af12e8b466
Disable for letting CI pass
6 years ago
Guy Carmeli
755ff262f9
Don't throw exception in some tests as there's no reason to
6 years ago
yogevbd
3fd9cdfe5b
fix flaky top bar transition
6 years ago
Guy Carmeli
a0982e404d
Report onActivityResult to RN
6 years ago
andresesfm
cba7d1796b
Reverting to public (#3146 )
We need this constructor to be accessible in order to integrate with CodePush
6 years ago
yogevbd
0cb95ef67f
documentation fix
6 years ago
Guy Carmeli
604247df1a
Delete unused logic
These two functions were related to previous modal implementation which relied on Dialogs
6 years ago
Guy Carmeli
e36c4b0e8d
Declare nativeCommandsSender explicitly
6 years ago
Guy Carmeli
7e94261afe
Reformat file
6 years ago
Guy Carmeli
096481e496
Destroy views when activity is destroyed and reloaded
6 years ago
Guy Carmeli
16f6ca41f9
f
6 years ago
Guy Carmeli
cb2d66f4c9
Expose adding reload listener through ReactGateway
6 years ago
Guy Carmeli
d4a1981141
Support listening to reload events
The reload listener currently doesn't properly pickup reloads from debug menu
6 years ago
Guy Carmeli
46405a2901
Properly destroy Overlays
6 years ago
Guy Carmeli
350f48aee1
Pass newly created ReactContext from ReactInstanceEventListener
6 years ago
Shalom Yerushalmy
4aabc4665e
Add headless option to e2e android
6 years ago
Shalom Yerushalmy
982fb6155d
Remove empty line to trigger build
6 years ago
Guy Carmeli
5a43de8cec
Use bound function
6 years ago
Guy Carmeli
3710a3ec90
Revert "Fixes NPE when initializing twice" (#3135 )
* Revert "Fix custom top bar from disappearing after a push (#3109 )"
This reverts commit 0e11b95f85 .
* Revert "Fixes NPE when initializing twice (#3128 )"
This reverts commit 0bf0751f5d .
6 years ago
frankenthumbs
0e11b95f85
Fix custom top bar from disappearing after a push (#3109 )
6 years ago
andresesfm
0bf0751f5d
Fixes NPE when initializing twice (#3128 )
6 years ago
yogevbd
9de6a1fe4b
Closes #3122
6 years ago
yogevbd
9f693b22f5
commands error handling
6 years ago
yogevbd
6b4da44fff
unit tests for setStackRoot
6 years ago
Shalom Yerushalmy
ed459cc985
Change CI env to JENKINS_CI
6 years ago
Shalom Yerushalmy
1d8a9d80f0
Fix lint
6 years ago
yogevbd
5ca136a3c3
Closes #3123
6 years ago
yogevbd
3b80ea8651
unit test fix
6 years ago