Browse Source

Run CI on PRs, fix lint + ts

Janic Duplessis 5 years ago
parent
commit
57264d4894
3 changed files with 3 additions and 2 deletions
  1. 1
    1
      .github/workflows/nodejs.yml
  2. 1
    1
      src/NativeSafeAreaView.web.tsx
  3. 1
    0
      tsconfig.json

+ 1
- 1
.github/workflows/nodejs.yml View File

@@ -1,6 +1,6 @@
1 1
 name: Node CI
2 2
 
3
-on: push
3
+on: [push, pull_request]
4 4
 
5 5
 jobs:
6 6
   build:

+ 1
- 1
src/NativeSafeAreaView.web.tsx View File

@@ -31,7 +31,7 @@ export default function NativeSafeAreaView({
31 31
         paddingBottom,
32 32
         paddingLeft,
33 33
         paddingRight,
34
-      } = getComputedStyle(element);
34
+      } = window.getComputedStyle(element);
35 35
 
36 36
       const insets = {
37 37
         top: paddingTop ? parseInt(paddingTop, 10) : 0,

+ 1
- 0
tsconfig.json View File

@@ -10,6 +10,7 @@
10 10
     "module": "commonjs",
11 11
     "strict": true,
12 12
     "moduleResolution": "node",
13
+    "skipLibCheck": true,
13 14
     "lib": ["dom", "es2015", "es2016", "esnext"],
14 15
     "jsx": "react-native"
15 16
   },