Browse Source

update README

Gaëtan Renaudeau 8 years ago
parent
commit
7d1d61b19e
1 changed files with 3 additions and 3 deletions
  1. 3
    3
      README.md

+ 3
- 3
README.md View File

@@ -69,8 +69,8 @@ Model tested: iPhone 6 (iOS), Nexus 5 (Android).
69 69
 | System             | iOS                | Android           |
70 70
 |--------------------|--------------------|-------------------|
71 71
 | View,Text,Image,.. | YES                | YES               |
72
-| WebView            | YES                | YES: with a `<View collapsable={false}>` parent |
73
-| gl-react           | YES                | NO (empty)        |
72
+| WebView            | YES                | YES, but from a `<View collapsable={false}>` parent |
73
+| gl-react v2        | YES                | NO (empty)        |
74 74
 | react-native-video | NO                 | NO                |
75 75
 | react-native-maps  | YES                | [NO](https://github.com/gre/react-native-view-shot/issues/36) |
76 76
 
@@ -84,7 +84,7 @@ Snapshots are not guaranteed to be pixel perfect. It also depends on the platfor
84 84
 
85 85
 ### specific to Android implementation
86 86
 
87
-- you need to make sure `collapsable` is set to `false` if you want to snapshot a **View**. Otherwise that view won't reflect any UI View. ([found by @gaguirre](https://github.com/gre/react-native-view-shot/issues/7#issuecomment-245302844))
87
+- you need to make sure `collapsable` is set to `false` if you want to snapshot a **View**. Some content might even need to be wrapped into such `<View collapsable={false}>` to actually make them snapshotable! Otherwise that view won't reflect any UI View. ([found by @gaguirre](https://github.com/gre/react-native-view-shot/issues/7#issuecomment-245302844))
88 88
 -  if you implement a third party library and want to get back a File, you must first resolve the `Uri`. (the `file` result returns an `Uri` so it's consistent with iOS and can be given to APIs like `Image.getSize`)
89 89
 
90 90
 ## Getting started