Fix lint errors

src/WebView.windows.tsx

@@ -25,7 +25,7 @@ import {
 } from './WebViewShared';
 import {
   NativeWebViewWindows,
-  WindowsWebViewProps,
+  WebViewSharedProps,
   WebViewProgressEvent,
   WebViewNavigationEvent,
   WebViewErrorEvent,
@@ -41,7 +41,25 @@ const RCTWebView: typeof NativeWebViewWindows = requireNativeComponent(
   'RCTWebView',
 );
 
-export default class WebView extends React.Component<WindowsWebViewProps, State> {
+const styles = StyleSheet.create({
+  container: {
+    flex: 1,
+  },
+  hidden: {
+    height: 0,
+    flex: 0, // disable 'flex:1' when hiding a View
+  },
+  loadingView: {
+    flex: 1,
+    justifyContent: 'center',
+    alignItems: 'center',
+  },
+  loadingProgressBar: {
+    height: 20,
+  },
+});
+
+export default class WebView extends React.Component<WebViewSharedProps, State> {
 
   static defaultProps = {
     javaScriptEnabled: true,
@@ -73,30 +91,27 @@ export default class WebView extends React.Component<WindowsWebViewProps, State>
       otherView = this.props.renderLoading && this.props.renderLoading();
     } else if (this.state.viewState === 'ERROR') {
       const errorEvent = this.state.lastErrorEvent;
-      otherView =
-        this.props.renderError &&
-        this.props.renderError(
+      otherView = this.props.renderError
+        && this.props.renderError(
           errorEvent.domain,
           errorEvent.code,
           errorEvent.description,
         );
     } else if (this.state.viewState !== 'IDLE') {
-      console.error(
-        'RCTWebView invalid state encountered: ' + this.state.viewState,
-      );
+      console.error('RCTWebView invalid state encountered: ', this.state.viewState);
     }
 
-    let webViewStyles = [styles.container, this.props.style];
+    const webViewStyles = [styles.container, this.props.style];
     if (
-      this.state.viewState === 'LOADING' ||
-      this.state.viewState === 'ERROR'
+      this.state.viewState === 'LOADING'
+      || this.state.viewState === 'ERROR'
     ) {
       // if we're in either LOADING or ERROR states, don't show the webView
       webViewStyles.push(styles.hidden);
     }
 
     const onShouldStartLoadWithRequest = createOnShouldStartLoadWithRequest(
-      this.onShouldStartLoadWithRequestCallback,
+      ()=>{},
       // casting cause it's in the default props
       originWhitelist as readonly string[],
       onShouldStartLoadWithRequestProp,
@@ -175,7 +190,9 @@ export default class WebView extends React.Component<WindowsWebViewProps, State>
 
   onLoadingStart = (event: WebViewNavigationEvent) => {
     const { onLoadStart } = this.props;
-    onLoadStart && onLoadStart(event);
+    if(onLoadStart) {
+      onLoadStart(event);
+    }
     this.updateNavigationState(event);
   }
 
@@ -189,8 +206,12 @@ export default class WebView extends React.Component<WindowsWebViewProps, State>
   onLoadingError = (event: WebViewErrorEvent) => {
     event.persist(); // persist this event because we need to store it
     const {onError, onLoadEnd} = this.props;
-    onError && onError(event);
-    onLoadEnd && onLoadEnd(event);
+    if(onError) {
+      onError(event);
+    }
+    if(onLoadEnd) {
+      onLoadEnd(event);
+    }
     console.error('Encountered an error loading page', event.nativeEvent);
     this.setState({
       lastErrorEvent: event.nativeEvent,
@@ -200,8 +221,12 @@ export default class WebView extends React.Component<WindowsWebViewProps, State>
 
   onLoadingFinish =(event: WebViewNavigationEvent) => {
     const {onLoad, onLoadEnd} = this.props;
-    onLoad && onLoad(event);
-    onLoadEnd && onLoadEnd(event);
+    if(onLoad) {
+      onLoad(event);
+    }
+    if(onLoadEnd) {
+      onLoadEnd(event);
+    }
     this.setState({
       viewState: 'IDLE',
     });
@@ -222,31 +247,4 @@ export default class WebView extends React.Component<WindowsWebViewProps, State>
     }
   }
 
-  onShouldStartLoadWithRequestCallback = (
-    _shouldStart: boolean,
-    _url: string,
-    _lockIdentifier: number,
-  ) => {
-  };
-
 }
-
-const styles = StyleSheet.create({
-  container: {
-    flex: 1,
-  },
-  hidden: {
-    height: 0,
-    flex: 0, // disable 'flex:1' when hiding a View
-  },
-  loadingView: {
-    flex: 1,
-    justifyContent: 'center',
-    alignItems: 'center',
-  },
-  loadingProgressBar: {
-    height: 20,
-  },
-});
-
-module.exports = WebView;

src/WebViewTypes.ts

@@ -319,7 +319,7 @@ export interface MacOSNativeWebViewProps extends CommonNativeWebViewProps {
 }
 
 export interface WindowsNativeWebViewProps extends CommonNativeWebViewProps {
-  testID?:string
+  testID?: string
 }
 
 export interface IOSWebViewProps extends WebViewSharedProps {
@@ -766,9 +766,6 @@ export interface AndroidWebViewProps extends WebViewSharedProps {
   allowsFullscreenVideo?: boolean;
 }
 
-export interface WindowsWebViewProps extends WebViewSharedProps{
-}
-
 export interface WebViewSharedProps extends ViewProps {
   /**
    * Loads static html or a uri (with optional headers) in the WebView.