Просмотр исходного кода

Merge branch 'master' into 0.7.0

Ben Hsieh 8 лет назад
Родитель
Сommit
7adb41b91c
3 измененных файлов: 10 добавлений и 4 удалений
  1. 1
    0
      .github/ISSUE_TEMPLATE
  2. 5
    0
      .github/PULL_REQUEST_TEMPLATE
  3. 4
    4
      README.md

+ 1
- 0
.github/ISSUE_TEMPLATE Просмотреть файл

@@ -0,0 +1 @@
1
+Hi ! Thank you for reporting an issue, but we would like to remind you, we have a trouble shooting page in our wiki. You may need to take a look on that page, perhaps the answer is just right there :p 

+ 5
- 0
.github/PULL_REQUEST_TEMPLATE Просмотреть файл

@@ -0,0 +1,5 @@
1
+Thank you for making a pull request ! Just a gentle reminder :)
2
+
3
+1. If the PR is offering a feature please make the request to our "Feature Branch" 0.7.0
4
+2. Bug fix request to "Bug Fix Branch" 0.6.4
5
+3. Correct README.md can directly to master

+ 4
- 4
README.md Просмотреть файл

@@ -1,8 +1,8 @@
1
-# react-native-fetch-blob ![release](https://img.shields.io/github/release/wkh237/react-native-fetch-blob.svg?maxAge=86400&style=flat-square) [![npm](https://img.shields.io/npm/v/react-native-fetch-blob.svg?style=flat-square)](https://www.npmjs.com/package/react-native-fetch-blob) ![](https://img.shields.io/badge/PR-Welcome-brightgreen.svg?style=flat-square) [![npm](https://img.shields.io/npm/l/express.svg?maxAge=2592000&style=flat-square)]() [![npm](https://img.shields.io/badge/inProgress-0.7.0-yellow.svg?style=flat-square)](https://github.com/wkh237/react-native-fetch-blob/milestones)
1
+# react-native-fetch-blob [![release](https://img.shields.io/github/release/wkh237/react-native-fetch-blob.svg?maxAge=86400&style=flat-square)](https://www.npmjs.com/package/react-native-fetch-blob) [![npm](https://img.shields.io/npm/v/react-native-fetch-blob.svg?style=flat-square)](https://www.npmjs.com/package/react-native-fetch-blob) ![](https://img.shields.io/badge/PR-Welcome-brightgreen.svg?style=flat-square) [![npm](https://img.shields.io/npm/l/express.svg?maxAge=2592000&style=flat-square)]() [![npm](https://img.shields.io/badge/inProgress-0.7.0-yellow.svg?style=flat-square)](https://github.com/wkh237/react-native-fetch-blob/milestones)
2 2
 
3 3
 A module provides upload, download, and files access API. Supports file stream read/write for process large files.
4 4
 
5
-**Why do we need this**
5
+**Rationale**
6 6
 
7 7
 React Native does not support `Blob` object at this moment, which means if you're going to send/receive binary data via `fetch` API, that might not work as you expect. See [facebook/react-native#854](https://github.com/facebook/react-native/issues/854).
8 8
 
@@ -44,9 +44,9 @@ Link package using [rnpm](https://github.com/rnpm/rnpm)
44 44
 rnpm link
45 45
 ```
46 46
 
47
-### For React Native >= 0.29
47
+### For React Native >= 0.29.0 (Android)
48 48
 
49
-The Android application template has changed in [react-native@0.29](https://github.com/facebook/react-native/releases/tag/v0.29.0) our rnpm link script may not working properly, if you encounters some error, please follow these instructions, Thanks @dphov, also see related issue  [#51](https://github.com/wkh237/react-native-fetch-blob/issues/51)
49
+> If you're using react-native >= `0.29.0`, the package might not be able to link through `rnpm link`, and you might see an error screen similar to [#51](https://github.com/wkh237/react-native-fetch-blob/issues/51), this is because a [a bug in 0.29.0](https://github.com/facebook/react-native/commit/4dabb575b1b311ba541fae7eabbd49f08b5391b3), someone has already fixed it, but the solution does not work on our project, you may have to manually add the package yourself.
50 50
 
51 51
 Add this code to `MainApplication.java`
52 52