Browse Source

Change confusing API naming #158

Ben Hsieh 7 years ago
parent
commit
99648e3435
2 changed files with 6 additions and 6 deletions
  1. 4
    4
      src/ios.js
  2. 2
    2
      src/ios/RNFetchBlob/RNFetchBlob.m

+ 4
- 4
src/ios.js View File

18
  * @param  {string} scheme URI scheme that needs to support, optional
18
  * @param  {string} scheme URI scheme that needs to support, optional
19
  * @return {Promise}
19
  * @return {Promise}
20
  */
20
  */
21
-function openDocument(path:string, scheme:string) {
21
+function previewDocument(path:string, scheme:string) {
22
   if(Platform.OS === 'ios')
22
   if(Platform.OS === 'ios')
23
-    return RNFetchBlob.openDocument('file://' + path, scheme)
23
+    return RNFetchBlob.previewDocument('file://' + path, scheme)
24
   else
24
   else
25
     return Promise.reject('RNFetchBlob.openDocument only supports IOS.')
25
     return Promise.reject('RNFetchBlob.openDocument only supports IOS.')
26
 }
26
 }
31
  * @param  {string} scheme URI scheme that needs to support, optional
31
  * @param  {string} scheme URI scheme that needs to support, optional
32
  * @return {Promise}
32
  * @return {Promise}
33
  */
33
  */
34
-function previewDocument(path:string, scheme:string) {
34
+function openDocument(path:string, scheme:string) {
35
   if(Platform.OS === 'ios')
35
   if(Platform.OS === 'ios')
36
-    return RNFetchBlob.previewDocument('file://' + path, scheme)
36
+    return RNFetchBlob.openDocument('file://' + path, scheme)
37
   else
37
   else
38
     return Promise.reject('RNFetchBlob.previewDocument only supports IOS.')
38
     return Promise.reject('RNFetchBlob.previewDocument only supports IOS.')
39
 }
39
 }

+ 2
- 2
src/ios/RNFetchBlob/RNFetchBlob.m View File

438
     [RNFetchBlobFS slice:src dest:dest start:start end:end encode:@"" resolver:resolve rejecter:reject];
438
     [RNFetchBlobFS slice:src dest:dest start:start end:end encode:@"" resolver:resolve rejecter:reject];
439
 })
439
 })
440
 
440
 
441
-RCT_EXPORT_METHOD(openDocument:(NSString*)uri scheme:(NSString *)scheme resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject
441
+RCT_EXPORT_METHOD(previewDocument:(NSString*)uri scheme:(NSString *)scheme resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject
442
 {
442
 {
443
     
443
     
444
     NSURL * url = [[NSURL alloc] initWithString:uri];
444
     NSURL * url = [[NSURL alloc] initWithString:uri];
455
 
455
 
456
 # pragma mark - open file with UIDocumentInteractionController and delegate
456
 # pragma mark - open file with UIDocumentInteractionController and delegate
457
 
457
 
458
-RCT_EXPORT_METHOD(previewDocument:(NSString*)uri scheme:(NSString *)scheme resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject
458
+RCT_EXPORT_METHOD(openDocument:(NSString*)uri scheme:(NSString *)scheme resolver:(RCTPromiseResolveBlock)resolve rejecter:(RCTPromiseRejectBlock)reject
459
 {
459
 {
460
     
460
     
461
     NSURL * url = [[NSURL alloc] initWithString:uri];
461
     NSURL * url = [[NSURL alloc] initWithString:uri];