Fix IOS memory leaks

src/ios/RNFetchBlob/RNFetchBlob.m

@@ -63,11 +63,10 @@ RCT_EXPORT_METHOD(fetchBlobForm:(NSDictionary *)options
                   callback:(RCTResponseSenderBlock)callback)
 {
 
-    [RNFetchBlobReqBuilder buildMultipartRequest:options taskId:taskId method:method url:url headers:headers form:form onComplete:^(NSURLRequest *req, long bodyLength) {
+    [RNFetchBlobReqBuilder buildMultipartRequest:options taskId:taskId method:method url:url headers:headers form:form onComplete:^(__weak NSURLRequest *req, long bodyLength) {
         // send HTTP request
         RNFetchBlobNetwork * utils = [[RNFetchBlobNetwork alloc] init];
         [utils sendRequest:options contentLength:bodyLength bridge:self.bridge taskId:taskId withRequest:req callback:callback];
-        utils = nil;
     }];
 
 }
@@ -80,13 +79,10 @@ RCT_EXPORT_METHOD(fetchBlob:(NSDictionary *)options
                   headers:(NSDictionary *)headers
                   body:(NSString *)body callback:(RCTResponseSenderBlock)callback)
 {
-    NSString *cType = [headers valueForKey:@"content-type"];
-    
     [RNFetchBlobReqBuilder buildOctetRequest:options taskId:taskId method:method url:url headers:headers body:body onComplete:^(NSURLRequest *req, long bodyLength) {
         // send HTTP request
-        RNFetchBlobNetwork * utils = [[RNFetchBlobNetwork alloc] init];
+        __block RNFetchBlobNetwork * utils = [[RNFetchBlobNetwork alloc] init];
         [utils sendRequest:options contentLength:bodyLength bridge:self.bridge taskId:taskId withRequest:req callback:callback];
-        utils = nil;
     }];
 }
 

src/ios/RNFetchBlobFS.m

@@ -304,9 +304,9 @@ NSMutableDictionary *fileStreams = nil;
     @try
     {
         [[self class] getPathFromUri:path completionHandler:^(NSString *path, ALAssetRepresentation *asset) {
-            NSData * fileContent;
+            __block NSData * fileContent;
             NSError * err;
-            Byte * buffer;
+            __block Byte * buffer;
             if(asset != nil)
             {
                 buffer = malloc(asset.size);
@@ -672,10 +672,11 @@ NSMutableDictionary *fileStreams = nil;
     if([uri hasPrefix:AL_PREFIX])
     {
         NSURL *asseturl = [NSURL URLWithString:uri];
-        ALAssetsLibrary* assetslibrary = [[ALAssetsLibrary alloc] init];
+        __block ALAssetsLibrary* assetslibrary = [[ALAssetsLibrary alloc] init];
         [assetslibrary assetForURL:asseturl
                        resultBlock:^(ALAsset *asset) {
-                           onComplete(nil, [asset defaultRepresentation]);
+                           __block ALAssetRepresentation * present = [asset defaultRepresentation];
+                           onComplete(nil, present);
                        }
                       failureBlock:^(NSError *error) {
                           onComplete(nil, nil);

src/ios/RNFetchBlobNetwork.m

@@ -109,11 +109,11 @@ NSOperationQueue *taskQueue;
 }
 
 // send HTTP request
-- (void) sendRequest:(NSDictionary  * _Nullable )options
+- (void) sendRequest:(__weak NSDictionary  * _Nullable )options
        contentLength:(long) contentLength
               bridge:(RCTBridge * _Nullable)bridgeRef
               taskId:(NSString * _Nullable)taskId
-         withRequest:(NSURLRequest * _Nullable)req
+         withRequest:(__weak NSURLRequest * _Nullable)req
             callback:(_Nullable RCTResponseSenderBlock) callback
 {
     self.taskId = taskId;
@@ -127,19 +127,19 @@ NSOperationQueue *taskQueue;
     NSString * path = [self.options valueForKey:CONFIG_FILE_PATH];
     NSString * ext = [self.options valueForKey:CONFIG_FILE_EXT];
 	NSString * key = [self.options valueForKey:CONFIG_KEY];
-    NSURLSession * session;
+    __block NSURLSession * session;
 
     bodyLength = contentLength;
 
     // the session trust any SSL certification
 
+    
     NSURLSessionConfiguration *defaultConfigObject = [NSURLSessionConfiguration defaultSessionConfiguration];
     if([options valueForKey:@"timeout"] != nil)
     {
         defaultConfigObject.timeoutIntervalForRequest = [[options valueForKey:@"timeout"] floatValue];
     }
     session = [NSURLSession sessionWithConfiguration:defaultConfigObject delegate:self delegateQueue:taskQueue];
-    
     if(path != nil || [self.options valueForKey:CONFIG_USE_TEMP]!= nil)
     {
         respFile = YES;
@@ -229,10 +229,13 @@ NSOperationQueue *taskQueue;
                      @"timeout" : @NO,
                      @"status": [NSString stringWithFormat:@"%d", statusCode ]
                      };
+        
         [self.bridge.eventDispatcher
          sendDeviceEventWithName: EVENT_STATE_CHANGE
          body:respInfo
-         ];
+        ];
+        headers = nil;
+        respInfo = nil;
     }
 
     if(respFile == YES)
@@ -259,7 +262,8 @@ NSOperationQueue *taskQueue;
 // download progress handler
 - (void) URLSession:(NSURLSession *)session dataTask:(NSURLSessionDataTask *)dataTask didReceiveData:(NSData *)data
 {
-    receivedBytes += [data length];
+    NSNumber * received = [NSNumber numberWithLong:[data length]];
+    receivedBytes += [received longValue];
     if(respFile == NO)
     {
         [respData appendData:data];
@@ -280,10 +284,18 @@ NSOperationQueue *taskQueue;
                 }
          ];
     }
+    received = nil;
 
 }
 
-- (void) URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCompleteWithError:(NSError *)error {
+- (void) URLSession:(NSURLSession *)session didBecomeInvalidWithError:(nullable NSError *)error
+{
+    if([session isEqual:session])
+        session = nil;
+}
+
+- (void) URLSession:(NSURLSession *)session task:(NSURLSessionTask *)task didCompleteWithError:(NSError *)error
+{
     
     self.error = error;
     [[UIApplication sharedApplication] setNetworkActivityIndicatorVisible:NO];
@@ -313,6 +325,9 @@ NSOperationQueue *taskQueue;
     [taskTable removeObjectForKey:taskId];
     [uploadProgressTable removeObjectForKey:taskId];
     [progressTable removeObjectForKey:taskId];
+    respData = nil;
+    receivedBytes = 0;
+    [session finishTasksAndInvalidate];
 }
 
 // upload progress handler

src/ios/RNFetchBlobReqBuilder.h

@@ -35,7 +35,7 @@
                          url:(NSString *)url
                      headers:(NSDictionary *)headers
                         form:(NSString *)body
-                  onComplete:(void(^)(NSURLRequest * req, long bodyLength))onComplete;
+                  onComplete:(void(^)(__weak NSURLRequest * req, long bodyLength))onComplete;
 
 +(NSString *) getHeaderIgnoreCases:(NSString *)field fromHeaders:(NSMutableArray *) headers;
 

src/ios/RNFetchBlobReqBuilder.m

@@ -34,7 +34,7 @@
     NSString * encodedUrl = url;
     
     // send request
-    NSMutableURLRequest *request = [[NSMutableURLRequest alloc] initWithURL:[NSURL URLWithString: encodedUrl]];
+    __block NSMutableURLRequest *request = [[NSMutableURLRequest alloc] initWithURL:[NSURL URLWithString: encodedUrl]];
     NSMutableDictionary *mheaders = [[NSMutableDictionary alloc] initWithDictionary:[RNFetchBlobNetwork normalizeHeaders:headers]];
     NSTimeInterval timeStamp = [[NSDate date] timeIntervalSince1970];
     NSNumber * timeStampObj = [NSNumber numberWithDouble: timeStamp];
@@ -42,7 +42,7 @@
     // generate boundary
     NSString * boundary = [NSString stringWithFormat:@"RNFetchBlob%d", timeStampObj];
     dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
-        NSMutableData * postData = [[NSMutableData alloc] init];
+        __block NSMutableData * postData = [[NSMutableData alloc] init];
         // combine multipart/form-data body
         [[self class] buildFormBody:form boundary:boundary onComplete:^(NSData *formData) {
             if(formData != nil) {
@@ -71,15 +71,15 @@
                       url:(NSString *)url
                   headers:(NSDictionary *)headers
                      body:(NSString *)body
-               onComplete:(void(^)(NSURLRequest * req, long bodyLength))onComplete
+               onComplete:(void(^)(__weak NSURLRequest * req, long bodyLength))onComplete
 {
 //    NSString * encodedUrl = [url stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding];
     NSString * encodedUrl = url;
     // send request
-    NSMutableURLRequest *request = [[NSMutableURLRequest alloc]
+    __block NSMutableURLRequest *request = [[NSMutableURLRequest alloc]
                                     initWithURL:[NSURL URLWithString: encodedUrl]];
 
-    NSMutableDictionary *mheaders = [[NSMutableDictionary alloc] initWithDictionary:[RNFetchBlobNetwork normalizeHeaders:headers]];
+    __block NSMutableDictionary *mheaders = [[NSMutableDictionary alloc] initWithDictionary:[RNFetchBlobNetwork normalizeHeaders:headers]];
     // move heavy task to another thread
     dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
         NSMutableData * blobData;
@@ -88,7 +88,7 @@
         if([[method lowercaseString] isEqualToString:@"post"] || [[method lowercaseString] isEqualToString:@"put"]) {
             // generate octet-stream body
             if(body != nil) {
-                NSString * cType = [[self class] getHeaderIgnoreCases:@"content-type" fromHeaders:mheaders];
+                __block NSString * cType = [[self class] getHeaderIgnoreCases:@"content-type" fromHeaders:mheaders];
                 // when headers does not contain a key named "content-type" (case ignored), use default content type
                 if(cType == nil)
                 {
@@ -97,7 +97,7 @@
                 
                 // when body is a string contains file path prefix, try load file from the path
                 if([body hasPrefix:FILE_PREFIX]) {
-                    NSString * orgPath = [body substringFromIndex:[FILE_PREFIX length]];
+                    __block NSString * orgPath = [body substringFromIndex:[FILE_PREFIX length]];
                     orgPath = [RNFetchBlobFS getPathOfAsset:orgPath];
                     if([orgPath hasPrefix:AL_PREFIX])
                     {
@@ -115,7 +115,7 @@
                 // otherwise convert it as BASE64 data string
                 else {
                     
-                    NSString * cType = [[self class]getHeaderIgnoreCases:@"content-type" fromHeaders:mheaders];
+                    __block NSString * cType = [[self class]getHeaderIgnoreCases:@"content-type" fromHeaders:mheaders];
                     // when content-type is application/octet* decode body string using BASE64 decoder
                     if([[cType lowercaseString] hasPrefix:@"application/octet"] || [[cType lowercaseString] containsString:@";base64"])
                     {