Browse Source

fix(android): Move noisy debug logging out of "quiet" log level. (#844)

Each time building our app, this library causes a message like this
one to be printed, sometimes twice:

  > Configure project :react-native-webview
  :react-native-webview:reactNativeAndroidRoot /home/greg/z/mobile/node_modules/react-native/android

Worse, the message comes through even if I silence all normal
progress messages and warnings, with `./gradlew --quiet`.

It turns out that the `logger.quiet` method which these log lines are
using has a confusing name.  It doesn't mean "log quietly", but more
like the opposite: "log even when asked to keep things quiet".  See
documentation on Gradle log levels:
  https://docs.gradle.org/current/userguide/logging.html

So, remove the noise by switching to `logger.info`.  This avoids
bothering the user by default, and keeps the information readily
available if desired by passing `--info` to Gradle.
Greg Price 4 years ago
parent
commit
b2cd6b54fa
1 changed files with 3 additions and 3 deletions
  1. 3
    3
      android/build.gradle

+ 3
- 3
android/build.gradle View File

72
       name androidSourcesName
72
       name androidSourcesName
73
     }
73
     }
74
 
74
 
75
-    logger.quiet(":${project.name}:reactNativeAndroidRoot ${defaultDir.canonicalPath}")
75
+    logger.info(":${project.name}:reactNativeAndroidRoot ${defaultDir.canonicalPath}")
76
     found = true
76
     found = true
77
   } else {
77
   } else {
78
     def parentDir = rootProject.projectDir
78
     def parentDir = rootProject.projectDir
97
           name androidSourcesName
97
           name androidSourcesName
98
         }
98
         }
99
 
99
 
100
-        logger.quiet(":${project.name}:reactNativeAndroidRoot ${androidPrebuiltBinaryDir.canonicalPath}")
100
+        logger.info(":${project.name}:reactNativeAndroidRoot ${androidPrebuiltBinaryDir.canonicalPath}")
101
         found = true
101
         found = true
102
       } else if (androidSourcesDir.exists()) {
102
       } else if (androidSourcesDir.exists()) {
103
         maven {
103
         maven {
105
           name androidSourcesName
105
           name androidSourcesName
106
         }
106
         }
107
 
107
 
108
-        logger.quiet(":${project.name}:reactNativeAndroidRoot ${androidSourcesDir.canonicalPath}")
108
+        logger.info(":${project.name}:reactNativeAndroidRoot ${androidSourcesDir.canonicalPath}")
109
         found = true
109
         found = true
110
       }
110
       }
111
     })
111
     })