react-native-webview

608 Commit

46 Rami (Branch)

Ramo (Branch): master

Commit Graph

Autore	SHA1	Messaggio	Data
aarondail	0442126595	fix(whitelisted origins): Prevent handling of un-whitelisted URLs * Preventing an unhandled promise rejection when: a URL is loaded by the WebView, but the URL isn't in the origin whitelist, so it is handed off to the OS to handle by calling Linking.openURL(), but Linking.openURL has an error. The code wasn't catching the error, so this would result in an unhandled promise rejection. Now the error is being caught. * Fixing a problem where a URL is handled to the OS to deal with, via Linking.openURL, and also loaded in the WebView by making those cases mutually exclusive (they weren't previously). In more detail: when a URL is loaded by the WebView that isn't in the origin whitelist it is handled off to the OS to handle by calling Linking.openURL. But, if the onShouldStartLoadWithRequest prop is set, then that function would also be called, and then that would determine whether the URL should be loaded. This can result in a situation where the URL is passed to Linking.openURL and onShouldStartLoadWithRequest returns true so it is also loaded in the WebView. The client can fix this by duplicating the origin whitelist logic in their onShouldStartLoadWithRequest of course, but this change makes it so they don't have to. Co-authored-by: Jason Safaiyeh <safaiyeh@protonmail.com>	4 anni fa
Thibault Malbranche	453b7dd3a0	feat(typescript): Source code rewrite using typescript (#425) Rewrote the whole repository into typescript. This will provide way better and up to date documentation. This should also add some safety for people contributing 😄 . Flow types were not working until now which is why this PR doesn't have them but feel free to PR. This also fixes #384 #435 #206 #171 #168.	5 anni fa
Malcolm Scruggs	fb78d13120	fix(webviewShared.js): Support all valid URI schemes and add testing (#293) * Change origin whitelist to allow for all valid URIs - Now supports +, -, and . - Prevent whitelist from matching when preceded by unwanted characters - URI must begin with letter - URI Scheme syntax: https://tools.ietf.org/html/rfc3986#section-3.1 * Add jest testing framework and run it on CI * Add tests for WebViewShared's createOnShouldStartLoadWithRequest	5 anni fa

Autore

SHA1

Messaggio

Data

aarondail

0442126595

fix(whitelisted origins): Prevent handling of un-whitelisted URLs

* Preventing an unhandled promise rejection when: a URL is loaded by the WebView, but the URL isn't in the origin whitelist, so it is handed off to the OS to handle by calling Linking.openURL(), but Linking.openURL has an error.  The code wasn't catching the error, so this would result in an unhandled promise rejection. Now the error is being caught.

* Fixing a problem where a URL is handled to the OS to deal with, via Linking.openURL, and also loaded in the WebView by making those cases mutually exclusive (they weren't previously).  In more detail: when a URL is loaded by the WebView that isn't in the origin whitelist it is handled off to the OS to handle by calling Linking.openURL.  But, if the onShouldStartLoadWithRequest prop is set, then that function would also be called, and then that would determine whether the URL should be loaded.  This can result in a situation where the URL is passed to Linking.openURL and onShouldStartLoadWithRequest returns true so it is also loaded in the WebView.  The client can fix this by duplicating the origin whitelist logic in their onShouldStartLoadWithRequest of course, but this change makes it so they don't have to.

Co-authored-by: Jason Safaiyeh <safaiyeh@protonmail.com>

4 anni fa

Thibault Malbranche

453b7dd3a0

feat(typescript): Source code rewrite using typescript (#425)

Rewrote the whole repository into typescript. This will provide way better and up to date documentation. This should also add some safety for people contributing 😄 .
Flow types were not working until now which is why this PR doesn't have them but feel free to PR.

This also fixes #384 #435 #206 #171 #168.

5 anni fa

Malcolm Scruggs

fb78d13120

fix(webviewShared.js): Support all valid URI schemes and add testing (#293)

* Change origin whitelist to allow for all valid URIs

- Now supports +, -, and .
- Prevent whitelist from matching when preceded by unwanted characters
- URI must begin with letter
- URI Scheme syntax: https://tools.ietf.org/html/rfc3986#section-3.1

* Add jest testing framework and run it on CI

* Add tests for WebViewShared's createOnShouldStartLoadWithRequest

5 anni fa

2 Commits (master)