Browse Source

remove xcpretty as it hides build errors

Daniel Zlotin 7 years ago
parent
commit
4063abb4df
2 changed files with 4 additions and 18 deletions
  1. 2
    8
      scripts/test.e2e.ios.js
  2. 2
    10
      scripts/test.unit.ios.js

+ 2
- 8
scripts/test.e2e.ios.js View File

@@ -7,7 +7,7 @@ function buildProjForDetox() {
7 7
   const scheme = release ? `playground_release` : `playground`;
8 8
   const conf = release ? `Release` : `Debug`;
9 9
 
10
-  const cmd = `RCT_NO_LAUNCH_PACKAGER=true
10
+  exec.execSync(`RCT_NO_LAUNCH_PACKAGER=true
11 11
             cd ./playground/ios && xcodebuild
12 12
             build
13 13
             -scheme ${scheme}
@@ -15,13 +15,7 @@ function buildProjForDetox() {
15 15
             -sdk iphonesimulator
16 16
             -configuration ${conf}
17 17
             -derivedDataPath ./DerivedData/playground
18
-            ONLY_ACTIVE_ARCH=YES`;
19
-
20
-  if (exec.which(`xcpretty`)) {
21
-    exec.execSync(`${cmd} | xcpretty && exit \${PIPESTATUS[0]}`);
22
-  } else {
23
-    exec.execSync(`${cmd}`);
24
-  }
18
+            ONLY_ACTIVE_ARCH=YES && echo $?`);
25 19
 }
26 20
 
27 21
 function runDetoxUsingMocha() {

+ 2
- 10
scripts/test.unit.ios.js View File

@@ -3,17 +3,9 @@ const exec = require('shell-utils').exec;
3 3
 
4 4
 const release = _.includes(process.argv, 'release');
5 5
 
6
-function runWithXcpretty(cmd) {
7
-  // if (exec.which(`xcpretty`)) {
8
-  //   exec.execSync(`${cmd} | xcpretty && exit \${PIPESTATUS[0]}`);
9
-  // } else {
10
-  exec.execSync(`${cmd}`);
11
-  // }
12
-}
13
-
14 6
 function run() {
15 7
   const conf = release ? `Release` : `Debug`;
16
-  runWithXcpretty(`RCT_NO_LAUNCH_PACKAGER=true
8
+  exec.execSync(`RCT_NO_LAUNCH_PACKAGER=true
17 9
           cd ./playground/ios && xcodebuild
18 10
             build build-for-testing
19 11
             -scheme "ReactNativeNavigation"
@@ -22,7 +14,7 @@ function run() {
22 14
             -configuration ${conf}
23 15
             -derivedDataPath ./DerivedData/playground
24 16
             ONLY_ACTIVE_ARCH=YES && echo $?`);
25
-  runWithXcpretty(`RCT_NO_LAUNCH_PACKAGER=true
17
+  exec.execSync(`RCT_NO_LAUNCH_PACKAGER=true
26 18
           cd ./playground/ios && xcodebuild
27 19
             test-without-building
28 20
             -scheme "ReactNativeNavigation"