浏览代码

enforce no console, disable e2e on travis temporarily

Daniel Zlotin 7 年前
父节点
当前提交
a00d3263d2
共有 4 个文件被更改,包括 4 次插入4 次删除
  1. 1
    1
      .eslintrc
  2. 3
    0
      playground/scripts/e2e.ios.js
  3. 0
    1
      src/adapters/NativeCommandsSender.js
  4. 0
    2
      src/commands/AppCommands.js

+ 1
- 1
.eslintrc 查看文件

@@ -26,7 +26,7 @@
26 26
       "error",
27 27
       "except-parens"
28 28
     ],
29
-    "no-console": "warn",
29
+    "no-console": "error",
30 30
     "no-constant-condition": "error",
31 31
     "no-control-regex": "error",
32 32
     "no-debugger": "warn",

+ 3
- 0
playground/scripts/e2e.ios.js 查看文件

@@ -58,6 +58,9 @@ function e2e() { //eslint-disable-line
58 58
 
59 59
 function run() {
60 60
   buildProjForDetox();
61
+  if (process.env.TRAVIS) {
62
+    console.warn('skipping e2e temporarily due to fbsimctl is currently broken'); //eslint-disable-line
63
+  }
61 64
   e2e();
62 65
 }
63 66
 

+ 0
- 1
src/adapters/NativeCommandsSender.js 查看文件

@@ -6,7 +6,6 @@ export default class NativeCommandsSender {
6 6
   }
7 7
 
8 8
   setRoot(layoutTree) {
9
-    console.log('layoutTree: ', JSON.stringify(layoutTree));
10 9
     this.nativeCommandsModule.setRoot(layoutTree);
11 10
     return Promise.resolve(layoutTree);
12 11
   }

+ 0
- 2
src/commands/AppCommands.js 查看文件

@@ -8,11 +8,9 @@ export default class AppCommands {
8 8
   }
9 9
 
10 10
   setRoot(simpleApi) {
11
-    console.log('AppCommands', 'setRoot');
12 11
     const input = _.cloneDeep(simpleApi);
13 12
     const layout = this.layoutTreeParser.parseFromSimpleJSON(input);
14 13
     this.layoutTreeCrawler.crawl(layout);
15
-    console.log('layout: ', JSON.stringify(layout));
16 14
     return this.nativeCommandsSender.setRoot(layout);
17 15
   }
18 16
 }