Browse Source

enforce no console, disable e2e on travis temporarily

Daniel Zlotin 7 years ago
parent
commit
a00d3263d2

+ 1
- 1
.eslintrc View File

26
       "error",
26
       "error",
27
       "except-parens"
27
       "except-parens"
28
     ],
28
     ],
29
-    "no-console": "warn",
29
+    "no-console": "error",
30
     "no-constant-condition": "error",
30
     "no-constant-condition": "error",
31
     "no-control-regex": "error",
31
     "no-control-regex": "error",
32
     "no-debugger": "warn",
32
     "no-debugger": "warn",

+ 3
- 0
playground/scripts/e2e.ios.js View File

58
 
58
 
59
 function run() {
59
 function run() {
60
   buildProjForDetox();
60
   buildProjForDetox();
61
+  if (process.env.TRAVIS) {
62
+    console.warn('skipping e2e temporarily due to fbsimctl is currently broken'); //eslint-disable-line
63
+  }
61
   e2e();
64
   e2e();
62
 }
65
 }
63
 
66
 

+ 0
- 1
src/adapters/NativeCommandsSender.js View File

6
   }
6
   }
7
 
7
 
8
   setRoot(layoutTree) {
8
   setRoot(layoutTree) {
9
-    console.log('layoutTree: ', JSON.stringify(layoutTree));
10
     this.nativeCommandsModule.setRoot(layoutTree);
9
     this.nativeCommandsModule.setRoot(layoutTree);
11
     return Promise.resolve(layoutTree);
10
     return Promise.resolve(layoutTree);
12
   }
11
   }

+ 0
- 2
src/commands/AppCommands.js View File

8
   }
8
   }
9
 
9
 
10
   setRoot(simpleApi) {
10
   setRoot(simpleApi) {
11
-    console.log('AppCommands', 'setRoot');
12
     const input = _.cloneDeep(simpleApi);
11
     const input = _.cloneDeep(simpleApi);
13
     const layout = this.layoutTreeParser.parseFromSimpleJSON(input);
12
     const layout = this.layoutTreeParser.parseFromSimpleJSON(input);
14
     this.layoutTreeCrawler.crawl(layout);
13
     this.layoutTreeCrawler.crawl(layout);
15
-    console.log('layout: ', JSON.stringify(layout));
16
     return this.nativeCommandsSender.setRoot(layout);
14
     return this.nativeCommandsSender.setRoot(layout);
17
   }
15
   }
18
 }
16
 }