Fix orientation android e2e

e2e/Orientations.test.js

@@ -8,6 +8,7 @@ describe('orientation', () => {
 
   beforeEach(async () => {
     await device.relaunchApp();
+    waitForDeviceToSettleAfterOrientationChangeAndroid = ms => new Promise(res => setTimeout(res, device.getPlatform() === 'ios' ? 0 : 10));
   });
 
   it('default allows all', async () => {
@@ -17,6 +18,7 @@ describe('orientation', () => {
     await device.setOrientation('landscape');
     await expect(elementById(testIDs.LANDSCAPE_ELEMENT)).toBeVisible();
     await device.setOrientation('portrait');
+    waitForDeviceToSettleAfterOrientationChangeAndroid();
     await expect(elementById(testIDs.PORTRAIT_ELEMENT)).toBeVisible();
     await elementById(testIDs.DISMISS_BUTTON).tap();
   });

e2e/OverlayTest.test.js

@@ -0,0 +1,35 @@
+const Utils = require('./Utils');
+const testIDs = require('../playground/src/testIDs');
+const { elementByLabel, elementById } = Utils;
+
+describe('Overlay', () => {
+  beforeEach(async () => {
+    await device.relaunchApp();
+  });
+
+  it('show and dismiss overlay', async () => {
+    await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
+    await elementById(testIDs.SHOW_OVERLAY_BUTTON).tap();
+    await expect(elementById(testIDs.DIALOG_HEADER)).toBeVisible();
+    await elementById(testIDs.OK_BUTTON).tap();
+    await expect(elementById(testIDs.DIALOG_HEADER)).toBeNotVisible();
+  });
+
+  it('overlay pass touches - true', async () => {
+    await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
+    await elementById(testIDs.SHOW_TOUCH_THROUGH_OVERLAY_BUTTON).tap();
+    await expect(elementById(testIDs.DIALOG_HEADER)).toBeVisible();
+    await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
+    await elementById(testIDs.HIDE_TOP_BAR_BUTTON).tap();
+    await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeNotVisible();
+  });
+
+  it('overlay pass touches - false', async () => {
+    await elementById(testIDs.PUSH_OPTIONS_BUTTON).tap();
+    await elementById(testIDs.SHOW_OVERLAY_BUTTON).tap();
+    await expect(elementById(testIDs.DIALOG_HEADER)).toBeVisible();
+    await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
+    await elementById(testIDs.HIDE_TOP_BAR_BUTTON).tap();
+    await expect(elementById(testIDs.TOP_BAR_ELEMENT)).toBeVisible();
+  });
+});

lib/android/app/src/main/java/com/reactnativenavigation/parse/params/Orientation.java

@@ -1,22 +1,19 @@
 package com.reactnativenavigation.parse.params;
 
 import android.content.pm.ActivityInfo;
-import android.content.res.Configuration;
 import android.support.annotation.Nullable;
 
 public enum Orientation {
-    Portrait("portrait", Configuration.ORIENTATION_PORTRAIT, ActivityInfo.SCREEN_ORIENTATION_PORTRAIT),
-    Landscape("landscape", Configuration.ORIENTATION_LANDSCAPE, ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE),
-    Default("default", Configuration.ORIENTATION_UNDEFINED, ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED),
-    PortraitLandscape("sensor", Configuration.ORIENTATION_UNDEFINED, ActivityInfo.SCREEN_ORIENTATION_USER);
+    Portrait("portrait", ActivityInfo.SCREEN_ORIENTATION_PORTRAIT),
+    Landscape("landscape", ActivityInfo.SCREEN_ORIENTATION_LANDSCAPE),
+    Default("default", ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED),
+    PortraitLandscape("sensor", ActivityInfo.SCREEN_ORIENTATION_USER);
 
     public String name;
-    public int configurationCode;
     public int orientationCode;
 
-    Orientation(String name, int configurationCode, int orientationCode) {
+    Orientation(String name, int orientationCode) {
         this.name = name;
-        this.configurationCode = configurationCode;
         this.orientationCode = orientationCode;
     }
 
@@ -29,13 +26,4 @@ public enum Orientation {
         }
         return null;
     }
-
-    public static String fromConfigurationCode(int configurationCode) {
-        for (Orientation orientation : values()) {
-            if (orientation.configurationCode == configurationCode) {
-                return orientation.name;
-            }
-        }
-        throw new RuntimeException();
-    }
 }