1. Sideenus weren't clickable on Android. It seems the order in which
child views were being added to parent controllers, left or right
before center, were affecting the ability to interact with the menus.
I've changed the code to always add them in a specific order: center,
then left, then right.
I believe this closes issue #2835.
https://github.com/wix/react-native-navigation/issues/2835.
2. On Android, merging options to open a menu works.
Navigation.mergeOptions(currentComponentId, {
sideMenu: {
left: {
visible: true
}
}
})
But merging options to close it wasn't working.
Navigation.mergeOptions(currentComponentId, {
sideMenu: {
left: {
visible: false
}
}
})
3. The bottom tabs controller was reserving a margin space for the tabs
when switching from one to another, regardless of its visibility
settings.
* setRoot({root:{}})
* support setRoot with root, modals, overlays
* Update setRoot calls in playground app to new api
* Update setRoot on Android to new api
currently only supporting root node
* Update setRoot on iOS to new api
* fix unit tests
* Update docs
Outdated onAppLaunched part is changed
I just started to a project with v2 and I realized this part of the documentation was wrong. I searched a bit and find this 2 commits:
104e3f97fd1d2680c5aa
So, that part is probably forgotten
* Modal unmount e2e test
* Modal unmount e2e test changes.
AHBottomNavigation recreates all tabs when some style properties are set.
This commit works around this issue by setting the problematic style properties
only if they are different then current values.
Related to #3132
* Implementation of passing multiple arguments to ImageLoader in order to avoid asynchronous issues and for performance as BottomBar re-creates all views every time an item is added
* removed redundant checks for testId
* Implementation of passing multiple arguments to ImageLoader in order to avoid asynchronous issues and for performance as BottomBar re-creates all views every time an item is added
* removed redundant checks for testId
* Set default statusBarBackgroundColor to Black
* Component and Parent controllers now extend ChildController
* Implement return to front logic for ChildControllers
* Apply statusBar color when view appears and returns to front
Outdated onAppLaunched part is changed
I just started to a project with v2 and I realized this part of the documentation was wrong. I searched a bit and find this 2 commits:
104e3f97fd1d2680c5aa
So, that part is probably forgotten
This commit removes NavigationOptionsListener as it was not needed anymore.
As a result, it uncovered a few issues which this commit also aims to fix.
* Set SideMenuController as parent of left, right and centre controllers
* Select tab by id with tabSelector interface
* mergeOptions now also applies options after merge - in ViewController base class
* Pull presentation logic from ComponentLayout to ComponentViewController
* Assign commandId to async commands
* CommandListener refactor
Pull listener out of Navigator and implement NativeCommandListener for native commands
* Emit onNavigationEvent when commands complete
* Rename timestamp to completionTime
* Rename NavigationEvent to EventEmitter
* Rename sendOnNavigationButtonPressed to emitOnNavigationButtonPressed
* Emit navigationEvent on bottom tab select
* rebase fix
* Emit commandCompleted event instead of nativeEvent
* fix native ios commands
* wait show and dismiss Overlay